Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix explicit close() on lazy connection when connection is active #109

Merged
merged 1 commit into from
May 20, 2019
Merged

Fix explicit close() on lazy connection when connection is active #109

merged 1 commit into from
May 20, 2019

Conversation

clue
Copy link
Contributor

@clue clue commented May 18, 2019

Resolves #108, thanks @choval for reporting!

@clue clue added this to the v0.5.4 milestone May 18, 2019
@clue clue mentioned this pull request May 18, 2019
Closed
@jsor jsor merged commit 541fe16 into friends-of-reactphp:master May 20, 2019
@clue clue deleted the lazy-close branch May 20, 2019 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

@jsor jsor jsor approved these changes

Assignees
No one assigned
Labels
bug easy pick
Projects
None yet
Milestone
v0.5.4
Development

Successfully merging this pull request may close these issues.

Called cancel on null on LazyConnection.php:220
3 participants
@clue @jsor @WyriHaximus