Reject pending commands if connection is closed #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsor
approved these changes
Jun 18, 2018
WyriHaximus
approved these changes
Jun 18, 2018
This was referenced Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that all outstanding commands will be rejected if the connection is closed.
As a first step, this PR performs a minor refactoring to avoid accessing an internal queue that only ever has a maximum of one single command anyway. This is not a BC break because its outside behavior is preserved (tests are not affected). Additionally, it ensures that the current command and any queued ones will be properly rejected with an
errorevent the connection is closed.Resolves / closes #44