Refactor internal parsing logic to separate Buffer class, remove dead code and improve performance #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Jun 18, 2018
jsor
approved these changes
Jun 19, 2018
This was referenced Jun 19, 2018
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors a fair bit of the internal parsing logic and moves buffering logic into a separate
Bufferclass that replaces the legacyBinaryclass which contained a lot of dead code. This significantly improves code quality, test coverage and parsing performance.This does not affect any of the outside behavior, so this should have no effect for consumers of this project. I've preserved individual commits to ease reviewing.
Builds on top of #53