Remove unneeded ConnectionInterface methods getState(), getOptions(), setOptions() and getServerOptions() #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple PR removes the (mostly under-documented)
getState()
,getOptions()
,setOptions()
andgetConnectionOptions()
methods from theConnectionInterface
. As of #64 and #65 the connection state is handled internally and is nothing consumers should have to worry about. Similarly, this now uses a URI for connecting instead of connection options.This is a BC break obviously, but empirical evidence including our examples suggests this should not affect most consumers.
Builds on top of #64 and #65