Add close() method to force-close the connection #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original
close()method was renamed toquit()(via #65) to emphasize this method actually sends a "quit" command over the wire once all queued commands are done (it waits for all queued commands, which is also why it now returns a promise). It does not force-close the connection like the streamclose()method commonly used in @reactphp does. This PR adds a newclose(): voidmethod which immediately force-closes the underlying connection and rejects all outstanding commands.Being a new addition to the
ConnectionInterface, this PR is technically a BC break. Empirical evidence suggests this should not affect most consumers (BC is limited due to #65 anyway).Builds on top of #69 and #65