Fix ConnectionInterface return type hint in Factory #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Factory class uses a socket connection in order to create the underlying database connection, but returns a higher-level MySQL connection interface from its local namespace. By using an aliased import, we no longer "overwrite" the local reference and fix IDE autocompletion and static analysis tools.
jsor
approved these changes
Feb 4, 2019
WyriHaximus
approved these changes
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Factory class uses a socket connection in order to create the
underlying database connection, but returns a higher-level MySQL
connection interface from its local namespace. By using an aliased
import, we no longer "overwrite" the local reference and fix IDE
autocompletion and static analysis tools.