Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for Microsoft Teams conversation references #311

Merged
merged 4 commits into from
May 30, 2024
Merged

Fixes for Microsoft Teams conversation references #311

merged 4 commits into from
May 30, 2024

Conversation

brendanrmoore
Copy link

@brendanrmoore brendanrmoore commented May 22, 2024 •
edited
Loading

  • Filter out the bot from the conversation members, so we don't attempt to create a conversation with the bot. This was throwing an error.
  • Use a getter and setter to make sure botApi#conversationReferences and Bot#conversationReferences reference the same object. Previously, these would get out of sync if you do something like botApi.conversationReferences = {...}.
  • Apply lint formatting.
  • Populate the conversation reference with extra user data.

@brendanrmoore brendanrmoore marked this pull request as ready for review May 22, 2024 16:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@leofmds leofmds requested a review from MichaelRyanWebber May 29, 2024 17:22
MichaelRyanWebber
MichaelRyanWebber approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@MichaelRyanWebber MichaelRyanWebber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Makes sense to me, appreciate the fixes

@MichaelRyanWebber MichaelRyanWebber added patch Increment the patch version when merged release Create a release when this pr is merged labels May 29, 2024
@MichaelRyanWebber MichaelRyanWebber merged commit b833ff1 into friggframework:version-0 May 30, 2024
4 of 5 checks passed
@seanspeaks seanspeaks added the released This issue/pull request has been released. label May 30, 2024
@seanspeaks
Copy link
Contributor

🚀 PR was released in @friggframework/api-module-microsoft-teams@0.4.5 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelRyanWebber MichaelRyanWebber MichaelRyanWebber approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brendanrmoore @seanspeaks @MichaelRyanWebber