Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: updated with features list #387

Merged
merged 5 commits into from
Dec 18, 2017
Merged

Readme: updated with features list #387

merged 5 commits into from
Dec 18, 2017

Conversation

fahad19
Copy link
Member

@fahad19 fahad19 commented Dec 16, 2017

The characteristics were initially listed in #386.

@fahad19 fahad19 self-assigned this Dec 16, 2017
@fahad19 fahad19 requested a review from a team December 16, 2017 18:40
@codecov
Copy link

codecov bot commented Dec 16, 2017

Codecov Report

Merging #387 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #387   +/-   ##
=======================================
  Coverage   97.33%   97.33%           
=======================================
  Files         101      101           
  Lines        3908     3908           
=======================================
  Hits         3804     3804           
  Misses        104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45248e4...e9cfa64. Read the comment docs.


* Gives your applications a **structure**
* **Environment** agnostic (runs in browser, server, and CLI)
* **Rendering** library agnostic (integrates with React, Vue, and Preact)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need comma after "Vue"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexmiranda: Lord of grammar, please shine your light upon us :D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that, thanks

README.md Outdated
* **Environment** agnostic (runs in browser, server, and CLI)
* **Rendering** library agnostic (integrates with React, Vue, and Preact)
* **Composable** with multiple packages as needed
* Each package focused on doing **one thing** well only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think "focused" should become either "focuses" or "is focused"
  2. The "...doing one thing well only" part reads weird. Maybe it should be "...doing one thing only and doing it well", or something shorter I can't come up with. Unix authors also couldn't :D https://en.wikipedia.org/wiki/Unix_philosophy#Do_One_Thing_and_Do_It_Well

README.md Outdated
* **Rendering** library agnostic (integrates with React, Vue, and Preact)
* **Composable** with multiple packages as needed
* Each package focused on doing **one thing** well only
* **Modular** architecture with Apps
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does "Apps" begin with capital letter? Shouldn't it be lowercase?

README.md Outdated
* Each package focused on doing **one thing** well only
* **Modular** architecture with Apps
* Embraces **reactive programming** with RxJS
* **Progressive** and easy to adopt it in existing applications
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need "it" in this sentence. Because the sentence already implies "It is" in the beginning:
"(It is) progressive and easy to adopt in existing applications".

README.md Outdated
* **Environment** agnostic (runs in browser, server, and CLI)
* **Rendering** library agnostic (integrates with React, Vue, and Preact)
* **Composable** with multiple packages as needed
* Each package is focused on doing **one thing** only and doint it well
Copy link
Contributor

@discosultan discosultan Dec 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing!!!

@viacheslaff
Copy link
Contributor

Very nice additions and clarifications!

@fahad19 fahad19 merged commit a35c26f into master Dec 18, 2017
@fahad19 fahad19 deleted the readme-features branch December 18, 2017 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants