Skip to content

Commit

Permalink
[BUG] Fix Move Info Overlay Scroll Bug (pagefaultgames#1856)
Browse files Browse the repository at this point in the history
* Added "Skip Dialogues" option (if at least 1 classic win)

* Removed error sound and hide option instead when classic wins = 0

* Add skip dialogues option to Unlockables and show unlocked message on first classic win

* Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage

* oops

* dont show charSprite when skipping a dialogue, small fixes

* correctly reset move description scrolling when changing move

* override fix

---------

Co-authored-by: Frederik Hobein <frederik.hobein@nterra.com>
  • Loading branch information
2 people authored and Frutescens committed Jun 10, 2024
1 parent f7c9849 commit e7cc7fd
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/ui/move-info-overlay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,11 @@ export default class MoveInfoOverlay extends Phaser.GameObjects.Container implem

this.desc.setText(move?.effect || "");

// stop previous scrolling effects
// stop previous scrolling effects and reset y position
if (this.descScroll) {
this.descScroll.remove();
this.descScroll = null;
this.desc.y = (this.options?.top ? EFF_HEIGHT : 0) + BORDER - 2;
}

// determine if we need to add new scrolling effects
Expand Down

0 comments on commit e7cc7fd

Please sign in to comment.