Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Textile (markup format) files #712

Closed
hoijui opened this issue Mar 27, 2023 · 2 comments
Closed

Add support for Textile (markup format) files #712

hoijui opened this issue Mar 27, 2023 · 2 comments
Labels
comment-styles Request for a new comment style, or fixing a bug with these good first issue Good for newcomers

Comments

@hoijui
Copy link
Contributor

hoijui commented Mar 27, 2023

Comment style for these files is documented here:
https://textile-lang.com/doc/textile-comments

They have a somewhat non-standard way for how their native comments work:

  • ###. starts a multi-line comment that ends with an empty line
  • ###.. starts a multi-line comment that ends with a for a new paragraph
  • ... but they also support normal HTML comments: <!-- BLA -->

Would it be fine if I'd add the .textile suffix simply with HtmlCommentStyle?
or should I rather implement a comment style that supports all three?
I can't say when I'd find the time for that.

@mxmehl mxmehl added good first issue Good for newcomers comment-styles Request for a new comment style, or fixing a bug with these labels Mar 28, 2023
@mxmehl
Copy link
Member

mxmehl commented Mar 28, 2023

If we can reuse an existing comment style, I'd personally prefer that. It only requires two new lines then:

  1. Adding the file extension to the list
  2. Adding a changelog entry ;)

@hoijui
Copy link
Contributor Author

hoijui commented Mar 28, 2023

will do then!

hoijui added a commit to hoijui/reuse-tool that referenced this issue Mar 28, 2023
Signed-off-by: Robin Vobruba <hoijui.quaero@gmail.com>
hoijui added a commit to hoijui/reuse-tool that referenced this issue Mar 28, 2023
Signed-off-by: Robin Vobruba <hoijui.quaero@gmail.com>
linozen added a commit that referenced this issue Apr 5, 2023
Adds mapping for Textile (`.textile`) files #712
@linozen linozen closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comment-styles Request for a new comment style, or fixing a bug with these good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants