Repair failing tests after upstream Git CVE-2022-39253 change #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
force-pushed
the
git-config
branch
from
c23833b
to
70e57fc
Compare
Setting check=True is a good sanity check. Previously some of these commands were silently failing. The thing that was really broken is related to the CVE-2022-39253 in upstream Git. New versions of Git no longer allow `git submodule add repository path` where repository is a file. We add a flag to explicitly allow this. See this URL for a meta analysis of the problem: https://vielmetti.typepad.com/logbook/2022/10/git-security-fixes-lead-to-fatal-transport-file-not-allowed-error-in-ci-systems-cve-2022-39253.html Signed-off-by: Carmen Bianca Bakker <carmenbianca@fsfe.org>
carmenbianca
force-pushed
the
git-config
branch
from
70e57fc
to
ddae5c7
Compare
Signed-off-by: Carmen Bianca Bakker <carmenbianca@fsfe.org>
carmenbianca
changed the title
|
I'm going to merge this to get all tests running again. Open PRs may need to be rebased on top of main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #617
Setting check=True is a good sanity check. Previously some of these
commands were silently failing.
The thing that was really broken is related to the CVE-2022-39253 in
upstream Git. New versions of Git no longer allow
git submodule add repository pathwhere repository is a file. We add a flag to explicitlyallow this.
See this URL for a meta analysis of the problem:
https://vielmetti.typepad.com/logbook/2022/10/git-security-fixes-lead-to-fatal-transport-file-not-allowed-error-in-ci-systems-cve-2022-39253.html