-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New formats support #632
New formats support #632
Conversation
Sure thing ! Should we consider adding support for other tools configuration files like |
1267e28
to
3d9add8
Compare
If you have suggestions, please do. Please provide some examples or references in the commit or discussion so we can refer to it at a later stage. |
Shouldn't I rather open an issue about that topic so we can discuss there the list of tools ? |
@sgaist yeah that would probably be best. |
In this case, should I remove the .clang-format commit from this PR and put it back when the tools file support discussion is done ? |
You can put it in
|
Thanks @carmenbianca I somehow missed that one. Will be perfect for #633. |
3d9add8
to
6b773a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6b773a9
to
9bd77fc
Compare
One thing I just realized, I have listed the specific issues per commit which can trigger quite a lot of noise on their respective page. I think I should rewrite the message of these commits and only mention the issues in the pull request. Agreed ? |
9bd77fc
to
777f775
Compare
I fixed the pylint issue and did the message change at the same time. |
eaa3c56
to
3405ff5
Compare
Added a change log. Will merge when tests succeed. Thank you @sgaist ! |
3405ff5
to
cfb1efc
Compare
.mjs is already present
This should also cover the proguard-rules.pro file mentionned in ticket 614
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
c21af7b
to
ee59ef1
Compare
This merge request implements a couple of requested format support.
Each format is in it's own commit to keep things clearly separated.
Fixes #575
Fixes #614
Fixes #616