Make _build.py compatible with msgfmt.py #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If gettext is not installed, _build.py falls back to msgfmt.py, which is provided by upstream Python. However, msgfmt.py is more sensitive to the order of arguments. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
|
Probably not related, but in the Docker build we also have an error on msgfmt: https://github.com/fsfe/reuse-tool/actions/runs/4211530610/jobs/7309939780#step:3:134 Can this be addressed here as well, or is it a separate issue? |
|
It's a separate issue. Thanks for noticing. Opened #693 to discuss that. |
mxmehl
approved these changes
Mar 13, 2023
|
LGTM 👍 Will merge now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If gettext is not installed, _build.py falls back to msgfmt.py, which is provided by upstream Python. However, msgfmt.py is more sensitive to the order of arguments.