Add license classifiers for Python/PyPI package #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
approved these changes
Apr 12, 2023
mxmehl
force-pushed
the
pypi-license-metadata
branch
from
ea5f17a
to
c95a8f7
Compare
This only concerns the metadata information for the Python package, picked up by e.g. PyPI. Currently, the valid SPDX license expression we provide in the license field isn't properly understood and displayed as a "proprietary or other" license. We hope that with these classifiers, this display will be closer to the truth.
mxmehl
force-pushed
the
pypi-license-metadata
branch
from
c95a8f7
to
fecf3b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the license on our PyPI package site is labelled as "Other/Proprietary License (Apache-2.0 AND CC0-1.0 AND GPL-3.0-or-later)". It's obvious that PyPI doesn't understand SPDX expressions yet.
Therefore, this PR adds the used licenses to the package metadata. Unfortunately, there is no classifier for CC-BY-SA-4.0 but I figured it's better to have incomplete data than no data. I hope that it will at least remove the "proprietary" label.
Needless to say that the current system of expressing licenses is not satisfactory. There is PEP 639 which is still in discussion.