Some followup work on the --json PR
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
These should reduce repetition and hopefully reduce errors. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Merged
carmenbianca
commented
Jun 13, 2023
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
I broke it during a previous commit. Because Python 3.7 is EOL in two weeks, I figure we can just drop it now. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca
force-pushed
the
cleanup-json
branch
from
a07dbdd
to
becd51f
Compare
nicorikken
reviewed
Jun 19, 2023
| foo.py | ||
| """ | ||
| new_kwargs = {} | ||
| for key, attr_val in self.__dict__.items(): |
There was a problem hiding this comment.
Just checking: there is no need to check the keys of the other dictionary as all keys are added on initiation and so the structure is the same.
There was a problem hiding this comment.
Correct, provided you have two ReuseInfo objects.
I considered the cases ReuseInfo.copy(SuperReuseInfo) and SuperReuseInfo.copy(ReuseInfo), but didn't write tests for them.
In the first case, the extra fields in SuperReuseInfo are not copied over into the new object, because they're not in ReuseInfo's dict.
In the second case, the extra fields in SuperReuseInfo cannot be overwritten because they do not exist in ReuseInfo.
nicorikken
approved these changes
Jun 19, 2023
linozen
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some refactoring work on top of the work done in #654.