Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show type hints for parameters in docs #772

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Conversation

carmenbianca
Copy link
Member

@carmenbianca carmenbianca commented Jun 21, 2023

Old:

Capture d’écran du 2023-06-21 14-53-22

New if still using sphinx_autodoc_typehints with different settings:

Capture d’écran du 2023-06-21 14-52-04

New with napoleon:

Screenshot from 2023-06-25 00-33-54

I went with Napoleon.

@carmenbianca carmenbianca marked this pull request as draft June 21, 2023 14:09
@carmenbianca carmenbianca marked this pull request as ready for review June 24, 2023 22:35
Copy link
Member

@nicorikken nicorikken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement. Confirmed it works. Approved, merge conflicts will have to be resolved.

I needed this to correctly regenerate the apidoc between `make docs`
runs.

Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
@carmenbianca carmenbianca merged commit 6783f2b into fsfe:main Oct 17, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants