Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Julia comment style #815

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Conversation

sorairolake
Copy link
Contributor

@sorairolake sorairolake commented Jul 31, 2023

Add the comment style for Julia.1 This supports both single-line comments and multi-line comments.

Also, single-line multi-line comments cannot be parsed with CommentStyle.parse_comment(), so I changed this to run CommentStyle._parse_comment_multi() first.

Footnotes

  1. https://docs.julialang.org/en/v1/base/punctuation/

@mxmehl mxmehl added the comment-styles Request for a new comment style, or fixing a bug with these label Jul 31, 2023
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR. I touched this up a little. I removed the tests because the tests are already generically done for all comment styles. The explicit tests for some other styles are a relic from before I made the tests generic, and they're kept for ease of debugging when something goes horrifically wrong.

Thanks a lot @sorairolake !

@carmenbianca carmenbianca merged commit d50b85e into fsfe:main Sep 23, 2023
20 checks passed
@sorairolake sorairolake deleted the feature/julia-comment branch September 23, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comment-styles Request for a new comment style, or fixing a bug with these
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants