Better error handling for DEP5 parse errors #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
force-pushed
the
fix-dep5-parse
branch
4 times, most recently
from
d9caa36
to
2d8337b
Compare
carmenbianca
force-pushed
the
fix-dep5-parse
branch
2 times, most recently
from
7565ee7
to
278953d
Compare
carmenbianca
commented
Oct 19, 2023
carmenbianca
commented
Oct 22, 2023
|
Copyright goes to FSFE, not Coop IT Easy. Fixed the commits. |
This was referenced Oct 24, 2023
Closed
carmenbianca
force-pushed
the
fix-dep5-parse
branch
2 times, most recently
from
1cdcf9c
to
fdf3b9d
Compare
This will help improve the error handling of DEP5 when the syntax is not valid. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Before, the Debian Copyright object was created lazily. When it is first needed, it is created. The Projects that were passed to other processes did not yet have Copyright objects (because they weren't yet needed, and can't be pickled). However, this sometimes resulted in every process separately trying to parse the DEP5 file, and failing. Now, the DEP5 file is parsed immediately instead of being lazily created. We circumvent the pickling problem by unsetting the attribute and re-parsing the file in the process. This is a bit stupid, but it shouldn't result in errors if the DEP5 file is not changed in the meantime. Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca
force-pushed
the
fix-dep5-parse
branch
from
fdf3b9d
to
8a1dcb8
Compare
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca
force-pushed
the
fix-dep5-parse
branch
from
cd79660
to
8fff9eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #803 by having better error handling.
Upstream PR to improve some exception catching: https://salsa.debian.org/python-debian-team/python-debian/-/merge_requests/123
After adding a duplicate Copyright field, the lint output looks like this: