Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Pijul VCS #858

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

korrat
Copy link
Contributor

@korrat korrat commented Oct 31, 2023

Pijul is a new VCS based on a theory of commutative patches. This commit adds support for Pijul to reuse-tool by implementing VCSStrategyPijul.

@carmenbianca
Copy link
Member

carmenbianca commented Oct 31, 2023

Hi @korrat

Thanks a heap for this PR! It looks pretty good. I fixed up some things that I swore I would fix whenever the third VCS is added to the tool (to reduce having to write if statements everywhere).

Before this can be merged, though, it needs a few things:

  • Some tests added
    • This needs a pijul_repository fixture in conftest, I think. I'm not sure if it does the rest automagically.
  • A change log entry.
  • Add yourself to AUTHORS.rst.
  • edit: Pijul needs to be installed in the CI for it to be tested.

Could you take care of these?

@korrat
Copy link
Contributor Author

korrat commented Oct 31, 2023

Yes, I will take care of that!

@carmenbianca
Copy link
Member

(Did a sneaky force push to fix a test I caused to fail)

@korrat
Copy link
Contributor Author

korrat commented Oct 31, 2023

I've done the first three things, and I think I also finished step 4, but let's wait on the workflows to confirm.

I've also rebased and force-pushed the branch to solve the conflict with main.

@carmenbianca
Copy link
Member

Awesome work @korrat !

I will review this soon. Thank you so much for your contribution :)

@korrat
Copy link
Contributor Author

korrat commented Nov 1, 2023

I fixed the installation of Pijul and the failing tests. Let me know if you would like me to rebase & squash the fixup commits (or everything).

And thanks a lot for the smooth contribution experience!

@mxmehl
Copy link
Member

mxmehl commented Nov 2, 2023

May I add that we also should mention an additional VCS on the website: https://reuse.software/faq/#no-git

VCSs are also mentioned in the README IIRC.

korrat and others added 5 commits November 9, 2023 10:55
Pijul is a new VCS based on tracking commutative patches. This commit
adds support for Pijul to reuse-tool by implementing VCSStrategyPijul.
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
Copy link
Member

@carmenbianca carmenbianca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I moved the Pijul tests to their own workflow. Thanks a lot for this contribution @korrat

@carmenbianca carmenbianca merged commit 8984867 into fsfe:main Nov 9, 2023
15 checks passed
@korrat korrat deleted the pijul-support branch November 10, 2023 16:42
@korrat
Copy link
Contributor Author

korrat commented Nov 10, 2023

Thank you very much for the great experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants