Ignore COPYING and LICENSE as exact matches or with extensions #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmenbianca
force-pushed
the
copying-license-fix
branch
from
c145e25
to
4147e2f
Compare
|
Uh, this will break things. I see many LICENSE.md or LICENSE.txt files around. I don't quite understand why this change is needed. Do you want to avoid that a file such as |
carmenbianca
force-pushed
the
copying-license-fix
branch
from
4147e2f
to
92a4a2b
Compare
carmenbianca
changed the title
Good shout. I changed this so that |
carmenbianca
commented
Jan 19, 2024
CHANGELOG.md
Outdated
Comment on lines
70
to
73
| - Previously, any file that begins with `COPYING` or `LICENSE` was ignored. This | ||
| has been changed. Now, files like `COPYING_README` are no longer ignored, but | ||
| `COPYING` and `COPYING.txt` are still ignored (in other words: exact matches, | ||
| or `COPYING` + a file extension). Idem ditto for `LICENSE`. (#886) |
There was a problem hiding this comment.
This is now in the 3.0.0 change log section…
mxmehl
approved these changes
Jan 29, 2024
Signed-off-by: Carmen Bianca BAKKER <carmenbianca@fsfe.org>
carmenbianca
force-pushed
the
copying-license-fix
branch
from
92a4a2b
to
0ed4d11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #881 and fsfe/reuse-docs#139