Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FSharp.Compiler.Service coreclr package is broken #591

Closed
matthid opened this issue Jun 26, 2016 · 1 comment
Closed

FSharp.Compiler.Service coreclr package is broken #591

matthid opened this issue Jun 26, 2016 · 1 comment

Comments

@matthid
Copy link
Contributor

matthid commented Jun 26, 2016

fsprojects/FAKE#1281

Please provide a succinct description of the issue. Opening a new fsi session fails:

System.Resources.MissingManifestResourceException: Could not find any resources appropriate for the specified culture or the neutral culture.  Make sure "FSIstrings.resources" was correctly embedded or linked into assembly "FSharp.Compiler.Service.netcore" at compile time, or that all the satellite assemblies required are loadable and fully signed.
   at System.Resources.ManifestBasedResourceGroveler.HandleResourceStreamMissing(String fileName)
   at System.Resources.ManifestBasedResourceGroveler.GrovelForResourceSet(CultureInfo culture, Dictionary`2 localResourceSets, Boolean tryParents, Boolean createIfNotExists, StackCrawlMark& stackMark)
   at System.Resources.ResourceManager.InternalGetResourceSet(CultureInfo requestedCulture, Boolean createIfNotExists, Boolean tryParents, StackCrawlMark& stackMark)
   at System.Resources.ResourceManager.InternalGetResourceSet(CultureInfo culture, Boolean createIfNotExists, Boolean tryParents)
   at System.Resources.ResourceManager.GetString(String name, CultureInfo culture)
   at FSIstrings.SR.GetStringFunc[T](String messageID, PrintfFormat`4 fmt)
   at <StartupCode$FSharp-Compiler-Service-netcore>.$FSIstrings.fsiProductName@270.Invoke(Tuple`2 tupledArg)
   at Microsoft.FSharp.Core.FSharpFunc`2.InvokeFast[V](FSharpFunc`2 func, T arg1, TResult arg2)
   at Microsoft.FSharp.Compiler.Interactive.Shell.FsiEvaluationSession.updateBannerText()
   at Microsoft.FSharp.Compiler.Interactive.Shell.FsiEvaluationSession..ctor(FsiEvaluationSessionHostConfig fsi, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, Boolean fsiCollectible)
   at Microsoft.FSharp.Compiler.Interactive.Shell.FsiEvaluationSession.Create(FsiEvaluationSessionHostConfig fsiConfig, String[] argv, TextReader inReader, TextWriter outWriter, TextWriter errorWriter, FSharpOption`1 collectible)

Repro steps

Steps are outlined in the first post of the linked issue.

Expected behavior

It should work.

Actual behavior

Exception (see above)

Known workarounds

None

Related information

CoreCLR

It seems like the resources are not named correctly in the FSharp.Compiler.Service.netcore assembly:

fsharp compiler service netcore_resourceerror

I'll try to come with a solution but wanted to report this here first in case someone wants to help or take it.

matthid added a commit to matthid/FSharp.Compiler.Service that referenced this issue Jun 26, 2016
@dsyme dsyme closed this as completed in 6b76676 Jun 26, 2016
dsyme added a commit that referenced this issue Jun 26, 2016
Properly embed 'FSIstrings' resource, fixes #591
@matthid matthid mentioned this issue Jul 2, 2016
58 tasks
@matthid
Copy link
Contributor Author

matthid commented Apr 9, 2017

Seems like this issue has come back :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant