Update FCS to latest #793
Merged
Update FCS to latest #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try to clean up error text a little.
update necessary VS references to 15.3
* Better error message for list/array init * add comma
Better error message when we forgot . in dictionary access
Remove weird recursive function
* dotnet SDK uses the msbuild TargetFramework property, so we need to change our build a bit. Renaming it to TargetDotnetProfile in our files * Overeager renaming * Don't forget the mono stuff
* Rename targets --part1 * Rename targets --part1 * Microsoft.FSharp.Targets has a T as does Microsoft.Portable.FSharp.Targets
* cleanup * Fixes #3170 * Adding a test
* Better error message for pattern matching * Better error message for pattern matching guards * fix test * Test pattern match guards * s/return type/have type
* Add IL output option for deterministic output Thread a new option through the options to the code writing the IL. For the moment just use a constant for deterministic timestamp, and use 0 as the timestamp in the MVID * Basic check to prevent wildcard version + deterministic at the same time * Hash the code, data and metadata, and use for mvid + timestamp * Fix fsc & fsci help tests by adding in new command line option for deterministic * tests for command line, wildcard versions, normal non-deterministic behaviour * Attempt to get CI to support timeout * Allow PRECMD to call FSI more than once, and use this for copying files and pausing to prevent race-condition * PortablePdbBuilder use consistent id If compiling deterministically, use deterministic id provider support in making a pdb builder. see https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/Portable/PEWriter/PeWriter.cs#L132 * Portable and Embedded pdb now deterministic * wip: fix up timestamp in pdb, but mvids still out of sequence * Fix breaking change from rebasing on master * Add notes about determinism with non portable pdbs Make the checks for finding embedded guids more strict and unique * Throw error if determinsitc build and non-portable pdb specified
* Tweak FSharp.Core.4.1.xxx nuspec definition for portable 259 * Correct profile259 path
* allow build of community FCS nuget pacakge from this repo * fix build of vs tests * build fcs nupkg * clean project files * build all FCS bits, incl right dependencies * fcs nuget updates * netstandard is not netcore * make FCS tests pass * make FCS tests pass * revert unintended change * fix build of FCS docs * remove explicit codegen from fcs .NETStandard build * remove explicit codegen from fcs .NETStandard build * add version numbers to DLLs * missing file * remove duplicate package
Fix issues around MailboxProcessor Thank you for this
* prevent endless async loop on Receive * don't run update loop on ui thread forever * Update LanguageService.fs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the FCS repo to the latest bits from visualfsharp, including the new build scripts
It's a big PR that is basically impossible to review
FUTURE