Add additional check in path normalization

fsktom · Jul 14, 2024 · cf0a738 · cf0a738
1 parent e23d939
commit cf0a738
Show file tree

Hide file tree

Showing 4 changed files with 50 additions and 48 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/endsong_ui/Cargo.lock b/endsong_ui/Cargo.lock
diff --git a/endsong_ui/src/plot.rs b/endsong_ui/src/plot.rs
@@ -130,8 +130,8 @@ fn normalize_path(path: &str) -> String {
     }
 
     // https://stackoverflow.com/a/1976050
-    if new_path.is_empty() {
-        new_path.push('_');
+    if new_path.is_empty() || new_path == "." {
+        new_path = "_".into();
     }
 
     new_path
@@ -157,8 +157,9 @@ mod tests {
         assert_eq!(normalize_path(" "), "_");
         assert_eq!(normalize_path("   "), "___");
 
-        // empty should be changed
+        // empty/only dot should be changed (Windows)
         assert_eq!(normalize_path(""), "_");
+        assert_eq!(normalize_path("."), "_");
 
         assert_eq!(normalize_path(" A|B<>B? "), "_A_B__B__");
 

diff --git a/endsong_ui/src/trace.rs b/endsong_ui/src/trace.rs
@@ -23,7 +23,8 @@ impl TraceType {
     }
 }
 
-/// Formats date for x-axis to `%Y-%m-%d %H:%M`
+/// Formats date for x-axis to `%Y-%m-%d %H:%M` to make sure plotly
+/// scales the x-axis properly
 ///
 /// I.e. "2016-09-01 15:06"
 fn format_date(date: &DateTime<Local>) -> String {