Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows #228

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Support Windows #228

merged 2 commits into from
Apr 30, 2020

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Apr 29, 2020

  • Implemented the function which extracts the creation time on Windows, so the program can be built.
    • Since the file creation time granularity is only down to 100ns, the tests are relaxed a bit.
  • Use filepath.Rel and filepath.ToSlash to calculate the object key from local path, rather than string manipulation, so the backslashes can be properly handled.

fsouza
fsouza approved these changes Apr 30, 2020
View reviewed changes
Copy link
Owner

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for contributing!

I'll enable Windows on the CI in a follow-up PR.

@fsouza fsouza merged commit c54c2a5 into fsouza:master Apr 30, 2020
@kennytm kennytm deleted the windows branch April 30, 2020 06:52
@kennytm kennytm mentioned this pull request Oct 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kennytm @fsouza