Fix mandatory parameters #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
reviewed
Jan 19, 2024
bartelink
reviewed
Jan 19, 2024
bartelink
reviewed
Jan 19, 2024
bartelink
approved these changes
Jan 19, 2024
There was a problem hiding this comment.
Thanks for taking the time to analyse and fix!
I'm not terribly familiar with this area of the code so no comments on the impl approach other than pointing out syntax things
Main thing is the test cases are good and the problem is solved.
Can you add a changelog entry to the release notes please?
|
Thanks for your time and effort; releasing shortly |
bartelink
pushed a commit
to bartelink/Argu
that referenced
this pull request
Feb 19, 2024
bartelink
pushed a commit
to bartelink/Argu
that referenced
this pull request
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a suggested correction for the regression in #127
resolves: #220