Skip to content

Commit

Permalink
Add "not yet migrated" obsolete attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
devcrafting committed Sep 18, 2017
1 parent a5fc7cb commit b474d43
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions help/markdown/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ We [learned from our mistakes](fake-fake5-learn-more.html), so we use the follow
- FAKE0001 for moving part from one Module to another
- FAKE0002 for removed API we don't know who is using it and how => please open an issue if you use it
- FAKE0003 for API that is no more accessible (basically became internal) => please open an issue if you use it
- FAKE0004 for API not yet migrated, waiting for your contribution
- Operators are opened seperatly with a separate `Operators` module
- We avoid the `Helpers` suffix (because we now expect users to write `<module>.<function>`)

Expand Down
6 changes: 2 additions & 4 deletions src/app/FakeLib/TargetHelper.fs
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,7 @@ let PrintDependencyGraph verbose target =
sb.Length <- sb.Length - Environment.NewLine.Length
log <| sb.ToString()

// TODO : why removed?
[<System.Obsolete("Use Fake.Core.Target instead (FAKE0001 - package: Fake.Core.Target - member: Fake.Core.Target.PrintRunningOrder)")>]
[<System.Obsolete("Not yet migrated, waiting for your contribution ;) (FAKE0004 - package: Fake.Core.Target - member: Fake.Core.Target.PrintRunningOrder to be created)")>]
let PrintRunningOrder() =
let sb = StringBuilder()
let appendfn fmt = Printf.ksprintf (sb.AppendLine >> ignore) fmt
Expand All @@ -477,9 +476,8 @@ let PrintRunningOrder() =
sb.Length <- sb.Length - Environment.NewLine.Length
log <| sb.ToString()

// TODO : why removed?
/// <summary>Writes a dependency graph of all targets in the DOT format.</summary>
[<System.Obsolete("Use Fake.Core.Target instead (FAKE0001 - package: Fake.Core.Target - member: Fake.Core.Target.PrintDotDependencyGraph)")>]
[<System.Obsolete("Not yet migrated, waiting for your contribution ;) (FAKE0004 - package: Fake.Core.Target - member: Fake.Core.Target.PrintDotDependencyGraph to be created)")>]
let PrintDotDependencyGraph () =
let sb = StringBuilder()
let appendfn fmt = Printf.ksprintf (sb.AppendLine >> ignore) fmt
Expand Down

0 comments on commit b474d43

Please sign in to comment.