Partial fix for #1395

[BlythMeister]

Targets now fire as early as possible.

However, targets will not move onto the next level until all targets on that level are completed.

Therefore, in the situation described in #1395 although T2.1 and T3 run along side each other, T2.2 waits until the longer running T3 has completed before starting even though it has no dependency on it.

[BlythMeister]

Hey @forki (or any other maintainer), any chance of getting this reviewed/merged?

[forki]

This looks like it's changing a lot of the internals. That's very risky.

@matthid what do you think?

[BlythMeister]

@forki @matthid I have added additional test coverage of scenarios and happy to add more if you can describe any :)

[matthid]

Might be a candidate to rebase on top of FAKE vnext (#1281)?

However, this probably means that is not released anytime soon... As I'm currently quite busy.

[matthid]

Otherwise it looks like a logical change to make... Do a lot of people depend on the parallel processing?

[BlythMeister]

As a compromise, I could look to make a flag which is passed on command like to run targets as early as possible?
That way it's not a change unless you opt in for it (which I would then do on my build script)

[forki]

I don't think we need a flag. Just enough confidence that it's correct

Am 12.10.2016 19:45 schrieb "Chris Blyth" notifications@github.com:

As a compromise, I could look to make a flag which is passed on command
like to run targets as early as possible?
That way it's not a change unless you opt in for it (which I would then do
on my build script)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1396 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AADgNJPpIVBOIM9sBtSjux7nUaC_96UQks5qzRzJgaJpZM4KQylc
.

[BlythMeister]

Ok, I've tried to create test scenarios to cover basics, the key to the change is the level adjustments.
I'm not sure what else I can do to increase confidence, but if you have anything I can try and implement it.

[forki]

we will put that in alpha for next minor version

[BlythMeister]

@forki there has been a few minor releases since october..any idea when this can be merge?