traceStartTask / traceEndTask: use 'use' block #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In many cases it explicitly either closes the task or throws, so maybe this was originally on purpose? Another approach could be to walk the stack on close, and close everything until the specified tag. Then I could revert my previous pr and it would "just work". |
|
I like the idea of the use thingy. Can you add that everywhere? |
0x53A
force-pushed
the
trace-start-end-task
branch
from
7992dff to
c6d091f
Compare
… that it is always closed, even if the task throws an exception." This reverts commit 88fde73.
0x53A
force-pushed
the
trace-start-end-task
branch
from
c6d091f to
a638345
Compare
…not to break user scripts
0x53A
force-pushed
the
trace-start-end-task
branch
from
a638345 to
ccda0fd
Compare
|
Ok that should be everything this time |
|
thanks so much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So it seems in my previous PR (#1379) I missed a few cases ...
The whole try / finally stuff just adds noise (in my opinion), what do you think about this IDisposable approach?
If you like it, I will go through all files (a full text search for traceStartTask found 114 lines in 59 files, so totally manageable).