Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly determine the 64-bit "Program Files" folder - fixes #1286 #1623

Merged
merged 1 commit into from
Aug 30, 2017

Conversation

TeaDrivenDev
Copy link
Contributor

The preferred way here would be just using Environment.SpecialFolder.ProgramFiles and Environment.SpecialFolder.ProgramFilesX86 for the two values, but that would require compiling Fake.exe as AnyCPU (with "Prefer 32-bit" off).

In a 32-bit process, both Environment.SpecialFolder.ProgramFiles and the environment variable ProgramFiles return the x86 folder. That means there is no official API to get the 64-bit Program Files folder from a 32-bit process, other than going to the registry, as mentioned in #1286.

Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine considering FAKE 5 is a new major.
Though we need to think about how those APIs should behave on unixes...

@matthid matthid merged commit b8fb237 into fsprojects:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants