fix some bugs. fix #1724 #1725
Merged
fix some bugs. fix #1724 #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matthid Can you release a version with these changes? |
|
@matthid Hello! |
|
Hi @vik-borisov, sorry that this takes a while. Today I'm travelling and probably won't enough internet to do a release of FAKE. So it might take a couple days. Strictly speaking it would be nice if a bugfix contains a unit-test/test to ensure we won't break it again. But I already reviewed your changes and agree that they are critical enough to do a release (therefore the review and bug label). Sorry for the delay, but it will definitely be part of the next release. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.