Add support for Kudu Zip Deploy #1757

panesofglass · 2018-01-13T16:05:27Z

Migrates all Fake.Azure modules to FAKE 5 and adds support for Kudu Zip Deploy. The initial implementation defines a ZipDeployParams type but does not define defaults.

FAKE 4 additions:

Fake.Azure.Kudu.ZipDeployParams
Fake.Azure.Kudu.zipDeploy

FAKE 5 Modules:

Fake.Azure.CloudServices
Fake.Azure.Emulators
Fake.Azure.Kudu
Fake.Azure.WebJobs

panesofglass · 2018-01-13T16:06:36Z

@isaacabraham, you may find this interesting. I started using it for our deployments, and it works quite well. Any modifications or suggested improvements are welcome.

panesofglass · 2018-01-13T16:32:36Z

src/app/FakeLib/AzureKudu.fs

+        Net.HttpWebRequest.Create(uri.AbsoluteUri + "api/zipdeploy",
+                                  Method = "POST",
+                                  ContentType = "multipart/form-data",
+                                  Timeout = 300000) :?> Net.HttpWebRequest


We might want to make this a parameter. If so, should this be a TimeSpan, time in seconds, or is milliseconds okay?

panesofglass · 2018-01-13T16:33:00Z

src/app/FakeLib/AzureKudu.fs

+    if response.StatusCode = Net.HttpStatusCode.OK then
+        logfn "Deployed %s" uri.AbsoluteUri
+    else
+        failwithf "Failed to deploy package with status code %A" response.StatusCode


What's the correct way to fail? What additional information should I provide?

panesofglass · 2018-01-13T16:34:42Z

src/app/FakeLib/AzureKudu.fs

+    // Get the response. If 200 OK, then the deploy succeeded. Otherwise, the deploy failed.
+    use response = request.GetResponse() :?> Net.HttpWebResponse
+    if response.StatusCode = Net.HttpStatusCode.OK then
+        logfn "Deployed %s" uri.AbsoluteUri


Is it appropriate to log out success? It's possible to request an asynchronous deployment that can be tracked by calling another API to check status. I used this approach for its simplicity and because I don't want to poll for status updates. However, I could understand a desire to switch to the polling model, if that's desired.

Please be aware that synchronous zip-deploys return 200 OK even if the deploy fails. I've suggested that they give better feedback on push deploys, but it doesn't look like they are prioritizing it: projectkudu/kudu#2641

You should probably do another call on 200 OK to check if the deploy actually succeeded or not.

panesofglass · 2018-01-13T16:35:42Z

src/app/FakeLib/AzureKudu.fs

+    // Write the zip file to the request stream, then flush and close it to send.
+    do  use fileStream = new FileStream(zipFile, FileMode.Open)
+        use inFile = request.GetRequestStream()
+        fileStream.CopyTo(inFile)


This seemed better than reading all the bytes and writing them. I also went with the synchronous (versus asynchronous) APIs. What's preferred?

panesofglass · 2018-01-13T20:54:04Z

@matthid what does the Fake 5 module required label mean?

matthid · 2018-01-14T00:18:11Z

In order to get rid of the old code-base I'd like to have code migrated to fake 5 modules. See http://fake.build/contributing.html#General-considerations

panesofglass · 2018-01-14T20:06:31Z

@matthid I'm happy to move the module to a Fake 5 module. It would be helpful to point out an example in the contributing.html.

matthid · 2018-01-14T22:36:03Z

@panesofglass you mean in addition to the steps outlined in http://fake.build/contributing.html#Porting-a-module-to-FAKE-5? Maybe a link to a PR like #1702 is sufficient? If yes please feel free to add that with this PR.

panesofglass · 2018-03-02T03:16:13Z

Sorry, I've not been able to get back to this. Feel free to leave it open if you want. I may be able to work on it some more during the MVP Summit. Otherwise, feel free to close it.

panesofglass · 2018-03-06T22:59:56Z

@matthid I'm not sure why the travis build is failing. What are the metaproj files?

matthid

I just marked the place I think relevant for travis... will review again before merging, but it looks pretty good. nice!

matthid · 2018-03-06T23:15:41Z

Fake.sln

@@ -4,77 +4,85 @@ VisualStudioVersion = 15.0.27130.2026
 MinimumVisualStudioVersion = 15.0.26124.0
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "app", "app", "{7BFFAE76-DEE9-417A-A79B-6A6644C4553A}"
 EndProject
-Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.Core.Context", "src/app/Fake.Core.Context/Fake.Core.Context.fsproj", "{D3D92ED7-C2B9-46D5-B611-A2CF0C30C8DB}"
+Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.Core.Context", "src\app\Fake.Core.Context\Fake.Core.Context.fsproj", "{D3D92ED7-C2B9-46D5-B611-A2CF0C30C8DB}"


I think dotnet core on linux has problems with this change. I think if you just replace \ with / and I think it will work.

Don’t ask me, feel free to report a bug to the dotnet guys...

panesofglass · 2018-03-07T17:40:04Z

@matthid Thanks! I changed the \ to /, and now it builds!

matthid

I'm ok with the changes (most comments are more of kind "suggestion" :)

The only real question is if we need documentation for these? (I'm thinking of something basic like https://fake.build/api-slack.html)

matthid · 2018-03-07T18:20:58Z

src/app/Fake.Azure.CloudServices/CloudServices.fs

+open Fake.IO.Globbing.Operators
+
+/// Configuration details for packaging cloud services.
+[<CLIMutable>]


Can we remove CLIMutable here?

I copied all this from the FakeLib project in an attempt to be helpful to get this moved to Fake 5.

Yes I know and this helps a lot! I just like APIs to be more consistent in fake5 so we can improve the code while porting - this moves the project forward. I see that people want to use stuff on fake5. That’s why I said the items are suggestions just in case you agree with them and have a minute ;)

matthid · 2018-03-07T18:21:22Z

src/app/Fake.Azure.CloudServices/CloudServices.fs

+      /// The name of the role in the service.
+      WorkerRole : string
+      /// The SDK version to use e.g. 2.2. If None, the latest available version is used.
+      SdkVersion : float option


Version is a float?

I copied all this from the FakeLib project in an attempt to be helpful to get this moved to Fake 5.

matthid · 2018-03-07T18:24:21Z

src/app/Fake.Azure.CloudServices/CloudServices.fs

+            |> Option.map(fun path -> Path.Combine(path, (packageCloudServiceParams.CloudService + ".cspkg")))
+            |> Option.map(sprintf "/out:%s")
+            |> defaultArg
+            <| ""


This is a bit unusual

I copied all this from the FakeLib project in an attempt to be helpful to get this moved to Fake 5.

matthid · 2018-03-07T18:27:06Z

src/app/Fake.Azure.Emulators/Emulators.fs

+            FileName = AzureEmulatorDefaults.StorageEmulatorToolPath.Value
+            Arguments = "stop" }) AzureEmulatorDefaults.TimeOut with
+    | Ok | StorageAlreadyStopped -> ()
+    | _ -> failwithf "Azure Emulator Failure on stop Storage Emulator"


Maybe we need some more information here, if you want to hide it you can use inner exceptions, like
raise <| exn("Azure Emulator Failure ...", exn(sprintf "Process exited with code %d" exitCode))

But that is only a suggestion if you left that information out on purpose, otherwise we might just include the exit code in the error message...

I copied all this from the FakeLib project in an attempt to be helpful to get this moved to Fake 5.

matthid · 2018-03-07T18:27:42Z

src/app/Fake.Azure.Kudu/Kudu.fs

+open System
+open System.IO
+#if NETSTANDARD
+open System.Net.Http


Can we always use System.Net.Http here?

Is it available in full framework? I copied this from the Fake.Api.Slack project.

matthid · 2018-03-07T18:28:50Z

src/app/Fake.Azure.Kudu/Kudu.fs

+/// Stages a set of files into a WebJob folder in the temp deployment area, ready for deployment into the website as a webjob.
+let stageWebJob webJobType webJobName files =
+    let webJobPath = getWebJobPath webJobType webJobName
+    Directory.CreateDirectory webJobPath |> ignore


Maybe Directory.ensure or however it is called ;)

matthid · 2018-03-07T18:30:02Z

src/app/Fake.Azure.Kudu/Kudu.fs

+#endif
+open Fake.Core
+open Fake.Core.Environment
+open Fake.Core.Trace


I'd recommend using Trace.* instead of opening. We might add RequireQualifiedAccess there as well...

matthid · 2018-03-07T21:33:45Z

Plan is to release this with the next release in a couple of days ;)

panesofglass · 2018-03-07T21:37:35Z

@matthid what else would you like me to do? I am not very confident in changing things in Emulators and CloudServices having not used nor reviewed them. I'm happy to use only System.Net.Http if that's available in both the Core and full framework versions. Anything else?

matthid · 2018-03-07T21:54:06Z

Like I said all is optional, this pr is green and I will merge and release it as is the next time I’m able to :) (sorry I’m clarifying because my communication is not always the best)

Regarding system.net.http I’d need to look at the nuget package, but it might be that it doesn’t support the framework we need. I can take a look after merging and try to fix here and in the slack package...

matthid · 2018-03-09T16:39:13Z

Thanks!

matthid added help wanted Fake 5 module required labels Jan 13, 2018

panesofglass commented Jan 13, 2018

View reviewed changes

matthid added the waiting for author Some information or action was requested and it needs to be addressed. Or a response from author label Feb 18, 2018

Add support for Kudu Zip Deploy

77700f4

panesofglass force-pushed the feature/kudu-zipdeploy branch 5 times, most recently from 3016c5f to a94b9b1 Compare March 6, 2018 01:18

Add FAKE 5 Azure modules

01c4bb7

panesofglass force-pushed the feature/kudu-zipdeploy branch from a94b9b1 to 01c4bb7 Compare March 6, 2018 17:02

Use System.Net.Http rather than System.Net for .NET Core

e001a5b

panesofglass force-pushed the feature/kudu-zipdeploy branch from 90cc7d5 to e001a5b Compare March 6, 2018 21:04

Fix remaining build errors

68d284f

matthid reviewed Mar 6, 2018

View reviewed changes

matthid removed Fake 5 module required waiting for author Some information or action was requested and it needs to be addressed. Or a response from author help wanted labels Mar 6, 2018

Attempt to fix Travis build

1efbe01

matthid approved these changes Mar 7, 2018

View reviewed changes

Address code review

a83ca62

matthid changed the base branch from master to beta_024 March 9, 2018 16:38

matthid merged commit 7408fdf into fsprojects:beta_024 Mar 9, 2018

matthid mentioned this pull request Mar 9, 2018

Beta 024 #1815

Merged

panesofglass deleted the feature/kudu-zipdeploy branch March 9, 2018 23:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Kudu Zip Deploy #1757

Add support for Kudu Zip Deploy #1757

panesofglass commented Jan 13, 2018 •

edited

Loading

panesofglass commented Jan 13, 2018

panesofglass Jan 13, 2018 •

edited

Loading

panesofglass Jan 13, 2018

panesofglass Jan 13, 2018

nikolaia Mar 1, 2018

panesofglass Jan 13, 2018

panesofglass commented Jan 13, 2018

matthid commented Jan 14, 2018

panesofglass commented Jan 14, 2018

matthid commented Jan 14, 2018

panesofglass commented Mar 2, 2018

panesofglass commented Mar 6, 2018

matthid left a comment

matthid Mar 6, 2018

panesofglass commented Mar 7, 2018

matthid left a comment

matthid Mar 7, 2018

panesofglass Mar 7, 2018 •

edited

Loading

matthid Mar 7, 2018

matthid Mar 7, 2018

panesofglass Mar 7, 2018 •

edited

Loading

matthid Mar 7, 2018

panesofglass Mar 7, 2018 •

edited

Loading

matthid Mar 7, 2018

panesofglass Mar 7, 2018 •

edited

Loading

matthid Mar 7, 2018

panesofglass Mar 7, 2018

matthid Mar 7, 2018

matthid Mar 7, 2018

matthid commented Mar 7, 2018

panesofglass commented Mar 7, 2018

matthid commented Mar 7, 2018

matthid commented Mar 9, 2018

Add support for Kudu Zip Deploy #1757

Add support for Kudu Zip Deploy #1757

Conversation

panesofglass commented Jan 13, 2018 • edited Loading

FAKE 4 additions:

FAKE 5 Modules:

panesofglass commented Jan 13, 2018

panesofglass Jan 13, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panesofglass commented Jan 13, 2018

matthid commented Jan 14, 2018

panesofglass commented Jan 14, 2018

matthid commented Jan 14, 2018

panesofglass commented Mar 2, 2018

panesofglass commented Mar 6, 2018

matthid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panesofglass commented Mar 7, 2018

matthid left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panesofglass Mar 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panesofglass Mar 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panesofglass Mar 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

panesofglass Mar 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

matthid commented Mar 7, 2018

panesofglass commented Mar 7, 2018

matthid commented Mar 7, 2018

matthid commented Mar 9, 2018

panesofglass commented Jan 13, 2018 •

edited

Loading

panesofglass Jan 13, 2018 •

edited

Loading

panesofglass Mar 7, 2018 •

edited

Loading

panesofglass Mar 7, 2018 •

edited

Loading

panesofglass Mar 7, 2018 •

edited

Loading

panesofglass Mar 7, 2018 •

edited

Loading