Fix inconsistent naming of MSBuild package, add setParams to run* methods

[sliepie]

Naming of MSBuild within module was inconsitent between MsBuild and MSBuild, since official naming is MSBuild I've renamed everything so it's consistent with official name.

Also added the setParams MSBuild.build function to the MSBuild.run* functions where applicable, so it's constent with other Fake 5 api's.
In Fake 4 this wasn't necessary because you could edit the mutable MSBuildDefaults property.

Also currently we have the following code in the MSBuild module:

 let mutable private MSBuildLoggers =
    []
    //[ ErrorLoggerName ]
    //|> List.map (fun a -> sprintf "%s,\"%s\"" a pathToLogger)

  do
    // Add MSBuildLogger to track build messages
    match BuildServer.buildServer with
    | BuildServer.AppVeyor ->
        MSBuildLoggers <- @"""C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll""" :: MSBuildLoggers
    //| BuildServer.TeamCity -> MSBuildLoggers <- sprintf "%s,\"%s\"" TeamCityLoggerName pathToLogger :: MSBuildLoggers
    | _ -> ()

Can this safely be removed? As we have now the BuildServer.* packages

The same applies to the following in MSBuildLogger:

(* TODO: Add to TeamCity
/// TeamCity Logger for MSBuild
type TeamCityLogger() =
    inherit MSBuildLogger()
    override this.RegisterEvents(eventSource) =
        eventSource.ErrorRaised.Add(fun a -> errToStr a |> TeamCityHelper.sendTeamCityError)
        *)

Finally is the NO_MSBUILD_AVAILABLE directive still necessary?
This directive is only used in Xamarin + MSBuild packages

[matthid]

Looks good to me. I always wondered about the correct casing...

Thanks for taking care of this! The only thing missing is to fix the CI. Let me know if things break apart.

[matthid]

To fix the build-script you need to nest this change into a #if BOOTSTRAP block

[sliepie]

The #if BOOTSTRAP trick didn't work when building on my laptop as it expected MsBuild instead of MSBuild.
However Travis and AppVeyor builds both needed MSBuild as I expected, the cause is probably some stale artifacts on my laptop.

[matthid]

Correct. Artefacts will be added to your .nuget folder (in your users directory). Maybe our build script needs to clean them...

[matthid]

Thanks!