Fake 5 InnoSetup Module

[kblohm]

Hi,
i created a module to support Inno Setup, a tool to build installers for windows.
Since there are other installer tools not yet ported i put the module under Fake.Installer.
If u want to use that namespace for an actual Fake-Installer, i can also put it under Fake.InstallerTools or something similair.

I also have a few questions:

• should new modules still be added into FakeLib.fsproj?
• if not, the build script probably needs to be modified. GenerateDocs docs only looks into the "./build" folder and as far as i can see FAKE.sln is only used to generate nuget packages. At least i suppose thats why i do not get any documentation generated :)

Thanks!

[matthid]

Thanks! I think the namespace is nice. I don't expect a critical conflict even if we do some kind of installer as this will be in a separate InnoSetup module (or something like that)

should new modules still be added into FakeLib.fsproj?

not necessarily, the general guideline is that all new stuff needs to be available as module. If people need stuff in the old fakelib adding it is fine for me.

if not, the build script probably needs to be modified. GenerateDocs docs only looks into the "./build" folder and as far as i can see FAKE.sln is only used to generate nuget packages. At least i suppose thats why i do not get any documentation generated :)

I think you found a huge pain point ;).
Actually currently we only generate docs for "fakelib" as it contains all the new apis as well (for migration purposes). If we now have a new module outside of fakelib we probably need to tackle that issue ...

[kblohm]

Hi,
i will try to fix the documentation issue for new modules. But that should probably be another PR.
If there is anything else i can do here, just tell me.

[matthid]

Hi, yes I think this is ready (I actually already changed to rc_9 in order to release this) you just slightly missed the release window ;)

[matthid]

This will afaik be a dead link, but yeah

[kblohm]

The docs are working locally for me now.
The only problem i have is that i need to change Fake.DotNet.FSFormatting for it to work. That might be fine, but since the build-script pulls that from nuget i am not sure what to do. I can reference the .fs file in the buildscript for now. Any thoughts? Should i just create a PR and u have a look at it there?

[matthid]

@kblohm Yes that is quite an unfortunate bootstrapping problem, I can tackle that if needed. Usually I just #load the required .fs files temporarily in that situation.

[matthid]

Thanks!