Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the template version #2055

Merged
merged 1 commit into from
Aug 11, 2018
Merged

Conversation

kblohm
Copy link
Contributor

@kblohm kblohm commented Aug 5, 2018

  • only add a version constraint if the user specified one
  • use * for DotNetCliToolReference if no version was specified
  • do not add --version for the global tool if no version was specified

* only add a version constraint if the user specified one
* use * for DotNetCliToolReference if no version was specified
* do not add --version for the global tool if no version was specified
@kblohm kblohm mentioned this pull request Aug 5, 2018
@@ -1,7 +1,11 @@
SET TOOL_PATH=(ToolPath)

IF NOT EXIST "%TOOL_PATH%\fake.exe" (
rem #if (version == "latest")
dotnet tool install fake-cli --tool-path ./%TOOL_PATH%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment here to tell users how to "lock" the version? Anyway we can add that later

@matthid
Copy link
Member

matthid commented Aug 5, 2018

Thanks for taking care of this. I released 5.3.1 already but this will be fixed next time :)

@kblohm
Copy link
Contributor Author

kblohm commented Aug 6, 2018

Looking at #2057, always downloading the latest version might not be what some people want. Then again, you can always specify a concrete version.

@matthid
Copy link
Member

matthid commented Aug 6, 2018

Yes ideally we would lock the version on dotnet new time, but I'm not if that is possible...

@matthid matthid merged commit 2bcfe48 into fsprojects:release/next Aug 11, 2018
@matthid
Copy link
Member

matthid commented Aug 11, 2018

Thanks!

@kblohm kblohm deleted the fixTemplate branch August 11, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants