Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Console runner to support space in temp path #2180

Closed
wants to merge 1 commit into from
Closed

Fix Console runner to support space in temp path #2180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/Fake.DotNet.Testing.NUnit/NUnit3.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ let internal createProcess (setParams : NUnit3Params -> NUnit3Params) (assemblie
//let processTimeout = TimeSpan.MaxValue // Don't set a process timeout. The timeout is per test.

let path = Path.GetTempFileName()
let args = (sprintf "@%s" path)
let args = (sprintf "\"@%s\"" path)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, can you instead use the Args class, this way it should work with other special cases of windows escaping horror as well. Also we might want to add a simple test to check that it is properly escaped.

CreateProcess.fromRawWindowsCommandLine tool args
|> CreateProcess.withFramework
|> CreateProcess.withWorkingDirectory (getWorkingDir parameters)
Expand Down Expand Up @@ -354,4 +354,4 @@ let run (setParams : NUnit3Params -> NUnit3Params) (assemblies : string seq) =
createProcess setParams assemblies
|> Proc.run

__.MarkSuccess()
__.MarkSuccess()