Release 5.16 #2357
Merged
Release 5.16 #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basing this off local testing and the slack api node sdk https://github.com/slackapi/node-slack-sdk/blob/e771e3c6fb346c42f6c86baba76223485c5c1024/packages/webhook/src/IncomingWebhook.ts#L92
Changed the namespace because the script I was testing with already had Fake added and I wasn't sure if #r-ing SlackNotification.fs into the script would mess up if they were in the same namespace. So I changed it and now I am deleting it.
Slack webhook username not from
Remove workaround
add rollforward policy to next-major
Push logic into findFiles
Add TargetCommitish to CreateReleaseParams
…nced over a year ago - #1820, existing packages are still available)
Conflicts: paket.lock src/app/Fake.Runtime/ScriptRunner.fs src/legacy/Fake.Deploy.Lib/Fake.Deploy.Lib.fsproj src/legacy/Fake.Deploy.Lib/app.config src/legacy/Fake.Deploy/Fake.Deploy.fsproj src/legacy/Fake.Deploy/app.config src/legacy/Test.Fake.Deploy.Web.File/Test.Fake.Deploy.Web.File.fsproj src/legacy/Test.Fake.Deploy.Web/Test.Fake.Deploy.Web.fsproj src/legacy/Test.Fake.Deploy.Web/app.config src/legacy/Test.Fake.Deploy/Test.Fake.Deploy.csproj src/legacy/Test.Fake.Deploy/app.config src/legacy/deploy.web/Fake.Deploy.Web.Abstractions/Fake.Deploy.Web.Abstractions.fsproj src/legacy/deploy.web/Fake.Deploy.Web.DataProviders/Fake.Deploy.Web.File/Fake.Deploy.Web.File.fsproj src/legacy/deploy.web/Fake.Deploy.Web.DataProviders/Fake.Deploy.Web.RavenDb/Fake.Deploy.Web.RavenDb.fsproj src/legacy/deploy.web/Fake.Deploy.Web/App.config src/legacy/deploy.web/Fake.Deploy.Web/Fake.Deploy.Web.fsproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fake.Deployfrom repository and NuGet package, see Announcement: Fake.Deploy and FakeLib are deprecated and will be removed #1820net461to support latestFSharp.Compiler.Serviceto fix Paket install gives error FS0192, FAKE Caching Error #2362FakeLib.dll(the original FAKE NuGet package)UsernamenotFrom, thanks @mastion - Slack webhook username not from #2360fake-cliwork in future dotnet sdk major version, thanks @baronfel - add rollforward policy to next-major #2372ProcessUtilsnow considersPATHEXTon windows - Push logic into findFiles #2368Fake.Api.GitHub] AddedTargetCommitishparameter to theCreateReleaseParamsrecord. This parameter is passed to Octokit's 'NewRelease', and allows for the creation of releases from arbitrary commits when the release tag does not exist yet, thanks @nikolamilekic - Add TargetCommitish to CreateReleaseParams #2367netstandard1.6andnet46(please open an issue if that actually hits you). All fake modules are now compiled fornetstandard2.0,net462andFSharp.Core 4.7, you should consider to upgrade your runtime.Fake.DotNet.FscandFake.DotNet.Fsinow use latestFSharp.Compiler.Service