-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Paket.Core to (better) support net5.0 #2556
Conversation
For some reason, the CI is failing, but if I'm looking right, this was the case in the main branch as well. I don't want to sound pushy, but I'm depending on a new release with my current work, so if there is anything I can do to speed up things I'd be happy to. |
@pchinery Thanks for the PR, see #2544 and fsprojects/Paket#3921 |
Is the current prerelease not working for you? |
if you mean 5.20.4-alpha.1642 then it doesn't work, it has the bug #2555. The pull request #2544 was before the latest changes to support .NET 5 subplatforms in paket like fsprojects/Paket#3942 or fsprojects/Paket#3933 |
Can we run the build again as it seems like an infrastructure error (System.Net.WebException: The remote server returned an error: (400) Bad Request.)? thanks |
I'm sorry, I thought that I had answered, but obviously I did not. I have not been aware of how to use pre-release versions of locals tools, but after your remark, I have updated fake-cli to the latest alpha and it does solve my problem, so thank you for sending me in the right direction! It probably still makes sense to update Paket.Core to the latest versions, even though I don't know to which extent the .net 5 support was improved in the meantime, but it appears to be pretty dynamic right now. |
net5.0 target works with current preview but net5.0-windows target doesn't |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it
Is it possible to get this shipped. Though not perfect, it adds some support for net5 and means that people can start using it in some cases? In fact, even if NOT using net5. Just having the latest paket means you can't run fake. |
fixes #2564 |
Hi Mattias, Anyway we can get this merged? If you feel it's good to go, of course. It seems like a straight forward fix. I think this can unblock many people. Thanks, |
@bengobeil the problem is not this change, but that the build went red because of some change in the environment. I'm not releasing with a red build. Additionally, on every release some maintenance work is needed (like release notes and stuff). Also, a lot of PRs in FAKE are newcomers in F# or quick hacks for some new use cases or something that changed somewhere else (new arguments or stuff like that). While I trust the current test coverage, I'd like to keep it that way (at least for as long as nobody else emerges as maintainer). This on the other side means additional maintenance to make sure changes meet the quality bar (reviews, writing tests, testing stuff if needed). |
Description
With the current release of Fake, I receive this error when targeting net5.0:
It was suggested in #2555 that this could be fixed by updating the integrated Paket.Core and this indeed work for me. With the compiled result, I can run my build again.