Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of SqlPackage code. #2634

Merged

Conversation

isaacabraham
Copy link
Contributor

Description

This refactors some of the SqlPackage code both for readability as well as for correctness in terms of using pattern matching and (importantly) safely unwrapping options rather than checks of IsSome and then .Value, which caused a bug with Timeout previously.

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

@yazeedobaid
Copy link
Collaborator

Thanks for the update on the SqlPackage module.

@yazeedobaid yazeedobaid merged commit 80b2ada into fsprojects:release/next Jan 17, 2022
@isaacabraham isaacabraham deleted the sqlpackage-refactor branch January 19, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants