Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing report types #2654

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Conversation

alcated
Copy link
Contributor

@alcated alcated commented Feb 7, 2022

Description

In order to convert a dotCover coverage result to a coverage file with Cobertura format, this coverage must have been done with the report type DetailedXML but type was missing.

See the configuration of dotCover console runner
See also ReportGenerator supported files format

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • (if new module) the module is in the correct namespace

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

@yazeedobaid
Copy link
Collaborator

@alcated Thanks for sending a PR!
Can you please target your PR to release/next branch since it is used for development?

@alcated alcated changed the base branch from master to release/next February 7, 2022 15:40
@alcated
Copy link
Contributor Author

alcated commented Feb 7, 2022

@yazeedobaid

@yazeedobaid yazeedobaid merged commit 7940ff1 into fsprojects:release/next Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants