Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish unit test results for pull request builds #2837

Merged
merged 2 commits into from
Sep 30, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,16 @@ on:
[push, pull_request]

jobs:
event_file: # Used for test reporting
name: "Publish event file"
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: EventFile
path: ${{ github.event_path }}

build:

runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -31,3 +41,9 @@ jobs:
with:
name: fake-artifacts-${{ matrix.os }}
path: release/artifacts
- name: publish test results
if: always()
uses: actions/upload-artifact@v4
with:
name: test-results-${{ matrix.os }}
path: testresults
47 changes: 47 additions & 0 deletions .github/workflows/publish-test-results.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# This is used to publish test results to PRs so that we can support external forks

name: Publish FAKE Test Results

on:
workflow_run:
workflows: ["FAKE Build and Test"]
types:
- completed
permissions: {}

jobs:
test-results:
name: Test Results
runs-on: ubuntu-latest
if: github.event.workflow_run.conclusion != 'skipped'

permissions:
checks: write
pull-requests: write
actions: read

steps:
# Download the Github event file
- name: Download Event file
uses: dawidd6/action-download-artifact@v4
with:
run_id: ${{ github.event.workflow_run.id }}
path: artifacts
name: EventFile

# Download all the test results files
- name: Download test results
uses: dawidd6/action-download-artifact@v4
with:
run_id: ${{ github.event.workflow_run.id }}
path: test-results
pattern: test-results-*

# Publish the test report
- name: Publish Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
with:
commit: ${{ github.event.workflow_run.head_sha }}
event_file: artifacts/event.json
event_name: ${{ github.event.workflow_run.event }}
files: "test-results/**/*.xml"
4 changes: 3 additions & 1 deletion build.fsx
Original file line number Diff line number Diff line change
Expand Up @@ -393,8 +393,10 @@ let callPaket wd args =
/// <param name="dllPath">Test assembly to run tests from</param>
/// <param name="resultsXml">Expecto test results XML file</param>
let runExpecto workDir dllPath resultsXml =
let resultsFile = "testresults" </> resultsXml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it stands, the test result xml files get written into the root directory of the repository, but it's easier to upload them in a batch if they all get written into a subdirectory and this looked like the easiest place to change to do that


let processResult =
DotNet.exec (dotnetWorkingDir workDir) (sprintf "%s" dllPath) (sprintf "--nunit-summary %s" resultsXml)
DotNet.exec (dotnetWorkingDir workDir) (sprintf "%s" dllPath) (sprintf "--nunit-summary %s" resultsFile)

if processResult.ExitCode <> 0 then
failwithf "Tests in %s failed." (Path.GetFileName dllPath)
Expand Down
Loading