Bug fix: Ensure to unescape special MSBuild characters. #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjvh80
force-pushed
the
char_escaping_in_csproj_bug
branch
from
f87f5c1 to
bc51566
Compare
|
did you already sign #598? we need to change license, so I can't merge before you sign. sorry. |
|
I had emailed the line already, but have now added it as a comment there too, so I think that would be a "yes". |
forki
added a commit
that referenced
this pull request
Dec 3, 2014
Bug fix: Ensure to unescape special MSBuild characters.
|
very cool thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a csproj file with an @ sign in it, as a dependency of the csproj file I'm building. This file is thus resolved as a reference by looking at the Include attribute which comes out as "%40...". So special MSBuild characters in that string are not unescaped. See http://msdn.microsoft.com/en-us/library/ms228186.aspx .