Look for MSTest in VS2015 location #843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while attempting to use the MSTest that it wouldn't find it if I was using VS 2015. The proposed fix adds the VS 2015 path, in the order demonstrated by the existing array, which has newer versions of VS closer to the beginning.
I got a very cryptic error with this issue, not fixed with this PR:
I also noticed that if FAKE can't find MSTest with a value from the
mstestPaths
array it supplies a path of "". Is that because it hopes to luck-out and find MSTest on the%PATH%
?While we are on the subject of paths to VS assets, would it be a better idea if all path computations regarding the VS location were done in one place so we don't have to (presumably) fix this in each case where we create a
mstestPaths
analog? Say for something likegacutil
(just thinking off the top of my head).Thanks,
Brody