Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for MSTest in VS2015 location #843

Merged
merged 1 commit into from
Jun 29, 2015
Merged

Look for MSTest in VS2015 location #843

merged 1 commit into from
Jun 29, 2015

Conversation

brodyberg
Copy link
Contributor

I noticed while attempting to use the MSTest that it wouldn't find it if I was using VS 2015. The proposed fix adds the VS 2015 path, in the order demonstrated by the existing array, which has newer versions of VS closer to the beginning.

I got a very cryptic error with this issue, not fixed with this PR:

System.Exception: Start of process  failed. Cannot start process because a file name has not been provided.

I also noticed that if FAKE can't find MSTest with a value from the mstestPaths array it supplies a path of "". Is that because it hopes to luck-out and find MSTest on the %PATH%?

While we are on the subject of paths to VS assets, would it be a better idea if all path computations regarding the VS location were done in one place so we don't have to (presumably) fix this in each case where we create a mstestPaths analog? Say for something like gacutil (just thinking off the top of my head).

Thanks,

Brody

@forki
Copy link
Member

forki commented Jun 29, 2015

yes I'm open for backwards-compatible improvements.

forki added a commit that referenced this pull request Jun 29, 2015
Look for MSTest in VS2015 location
@forki forki merged commit bc1ba60 into fsprojects:master Jun 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants