Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass OutputDataReceived to logfn instead of trace #906

Merged
merged 1 commit into from
Aug 12, 2015

Conversation

koenmetsu
Copy link
Contributor

This to prevent the colors from becoming all warbled (see scrshot)
fake_green

@forki
Copy link
Member

forki commented Aug 12, 2015

thx

forki added a commit that referenced this pull request Aug 12, 2015
Pass OutputDataReceived to logfn instead of trace
@forki forki merged commit dfee59c into fsprojects:master Aug 12, 2015
@inosik
Copy link
Contributor

inosik commented Aug 12, 2015

Seems like this broke the build.

@koenmetsu
Copy link
Contributor Author

Sorry about that, should be logfn with a format or just log, not sure which one is better. I'm not in a position to test this until tomorrow morning CEST, so feel free to revert or fix if urgent.

@inosik
Copy link
Contributor

inosik commented Aug 12, 2015

Actually I was about doing something else, but this change didn't let me compile. I reverted it for now in my local repo, but it isn't urgent, so I can wait.

@forki
Copy link
Member

forki commented Aug 12, 2015

Will fix tomorrow
On Aug 12, 2015 7:20 PM, "Ilja Nosik" notifications@github.com wrote:

Actually I was about doing something else, but this change didn't let me
compile. I reverted it for now in my local repo, but it isn't urgent, so I
can wait.


Reply to this email directly or view it on GitHub
#906 (comment).

@koenmetsu
Copy link
Contributor Author

Fixed in #907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants