Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor SquirrelHelper #910

Merged
merged 5 commits into from
Aug 18, 2015
Merged

Refactor SquirrelHelper #910

merged 5 commits into from
Aug 18, 2015

Conversation

inosik
Copy link
Contributor

@inosik inosik commented Aug 14, 2015

I actually wanted to add the --setupIcon-Parameter only (which isn't mentioned in the docs of Squirrel), but ended up reworking the existing code a bit, because of some issues (e. g. Squirrel ignoring the --loadingGif-Parameter).

Tell me if I should split this PR up, otherwise this is ready to merge.

inosik added 5 commits August 13, 2015 20:04
This allows us to specify a custom icon for the created Setup.exe-File.
* LoadingGif- and BootstrapperExe-Parameter:
  The space between the parameter name and the value caused Squirrel
  to ignore the value.

* Don't append the /a-Parameter twice
This allows us to pass paths which contain spaces to Squirrel.exe.
forki added a commit that referenced this pull request Aug 18, 2015
@forki forki merged commit dca6a15 into fsprojects:master Aug 18, 2015
@inosik inosik deleted the squirrel/refactor branch August 20, 2015 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants