Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup RegistryHelper.fs #980

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Cleanup RegistryHelper.fs #980

merged 1 commit into from
Oct 15, 2015

Conversation

lulu-berlin
Copy link
Contributor

  • Group functions meaningfully: (1) key, (2) value, (3) subkey.
  • The paramater indicating a registry value name is called "name" rather than "value", following the convention of Microsoft.
  • deleteRegistrySubKey follows the signature of createRegistrySubKey (that was there before): baseKey (HKEYLocalMachine, etc.) + subKey. This means that the subKey string must indicate the full path to the subkey (e.g. "SOFTWARE\Microsoft\VisualStudio").

@lulu-berlin
Cleanup RegistryHelper.fs
0010159 
- Group functions meaningfully: (1) key, (2) value, (3) subkey.
- The paramater indicating a registry value name is called "name" rather than "value", following the convention of Microsoft.
- deleteRegistrySubKey follows the signature of createRegistrySubKey (that was there before): baseKey (HKEYLocalMachine, etc.) + subKey. This means that the subKey string must indicate the full path to the subkey (e.g. "SOFTWARE\\Microsoft\\VisualStudio").
@lulu-berlin
Copy link
Contributor Author

@forki, here are the additional fixes we discussed in #976. This would close #966.

forki added a commit that referenced this pull request Oct 15, 2015
@forki
Merge pull request #980 from yever/RegistryHelper
f391d58 
Cleanup RegistryHelper.fs
@forki forki merged commit f391d58 into fsprojects:master Oct 15, 2015
@forki
Copy link
Member

forki commented Oct 15, 2015

thx

@lulu-berlin lulu-berlin mentioned this pull request Oct 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lulu-berlin @forki