-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TaskSeq.tryitem
, item
, tryLast
, last
, tryHead
, head
, tryPick
, pick
, tryFind
, find
, choose
, filter
, isEmpty
and more for IAsyncEnumerable<'T>
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem and corresponding documentation and exceptions
… last, tryItem, item
… need to keep the fsi up-to-date
… want blocking calls can always call Task.Result
…nc), tryPick(Async), tryFind(Async) and add signatures and documentation
abelbraaksma
changed the title
Add TaskSeq.tryitem, item, tryLast, last, tryHead, head
Add TaskSeq.tryitem, item, tryLast, last, tryHead, head, tryPick, pick, tryFind, find, choose, filter, isEmpty and more
Oct 14, 2022
Revert "Troubleshooting CI, remove OfXXX, CE, Other and ToXXX" This reverts commit 6856b9e. Turn TaskSeq.empty into a unit-function Troubleshooting CI, remove Item, Pick, CE Revert "Troubleshooting CI, remove Item, Pick, CE" This reverts commit bc6c260. Several attempts at troubleshooting CI issue, see log details and #25 Temporarily killing most tests, to troubleshoot hanging CI Revert "Temporarily killing most tests, to troubleshoot hanging CI" This reverts commit b84fff1. Troubleshooting CI, adding back several new tests Temporarily killing most tests, to troubleshoot hanging CI Revert "Temporarily killing most tests, to troubleshoot hanging CI" This reverts commit b84fff1. Troubleshooting CI, adding back several new tests Revert "Troubleshooting CI, adding back several new tests" This reverts commit 5ecf179. Troubleshooting CI, re-enabling only some tests, including new perf tests Revert "Troubleshooting CI, re-enabling only some tests, including new perf tests" This reverts commit 602cb3a. Troubleshooting CI, removing only the new perf tests Revert "Troubleshooting CI, removing only the new perf tests" This reverts commit d16f739. Troubleshooting CI, up until Iter is included Revert "Troubleshooting CI, up until Iter is included" This reverts commit 7f63395. Troubleshooting CI, up until Iter is removed (excluded) This reverts commit 7f63395. Revert "Troubleshooting CI, up until Iter is removed (excluded)" This reverts commit 32d463b. Troubleshooting CI, tests for Last, Map and Pick excluded Revert "Troubleshooting CI, tests for Last, Map and Pick excluded" This reverts commit 9132fee. Troubleshooting CI: remove all tests but Choose tests Troubleshooting CI, add hang timeout test Revert "Troubleshooting CI: remove all tests but Choose tests" This reverts commit 93cfda5. Troubleshooting CI, removing deliberately hanging test, leave blame-detection in test.yaml Troubleshooting hanging CI: order test cases (currently only within a class, not sure how to change it) Troubleshooting CI, re-enable parallelization of tests and clean code
abelbraaksma
force-pushed
the
add-tryitem-tryfind-etc
branch
from
October 14, 2022 19:55
8ddfbf9
to
c2a0657
Compare
Important note: I have disabled parallel test runs due to a race condition that was hard to pin down. Dozens of commits and reverts have been squashed back into one, to keep a clean history. See #25 for further investigation. |
abelbraaksma
changed the title
Add TaskSeq.tryitem, item, tryLast, last, tryHead, head, tryPick, pick, tryFind, find, choose, filter, isEmpty and more
Add Oct 14, 2022
TaskSeq.tryitem
, item
, tryLast
, last
, tryHead
, head
, tryPick
, pick
, tryFind
, find
, choose
, filter
, isEmpty
and more for IAsyncEnumerable<'T>
10 tasks
abelbraaksma
added
the
topic: surface area
Adds functions to the public surface area
label
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First batch of the functions mentioned in #22, see title.
Implemented the following (WIP):
The signatures
(WIP, will update)completed: