-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle RazorEngine.dll which works on mono #203
Comments
Just some notes:
|
I'm pretty sure @tpetricek would prefer the third option, but just a hack to fix on mono would be ok. |
If we bundle a version of razor dll, it's important to capture how to rebuild that custom version somewhere |
I have added https://www.nuget.org/packages/RazorEngine.N/ but I'm unable to setup paket to work with this (paket bug or did I setup invalid dependencies in the package?)
|
@matthid the paket issue may be related to fsprojects/Paket#140 |
It's not really a bug. But yes paket doesn't support conditional
|
…anually in src/nugetDependencies instead of paket (see issue fsprojects#203).
Thanks! I worked around this by using nuget directly instead of paket. |
Actually I don't it's a good idea to use such a hybrid solution with paket Why do you have this strange dependency in the package? That doesn't really
|
I don't think this is such a good idea as well, but what are the alternatives? I guess its fine to leave it this way until paket supports this? What do you mean, what kind of dependency would you suggest instead? |
Paket will probably never support a conditional dependency to the same
|
Why do you have this splitted dependency? This feels like a big hack around versioning. |
This can be needed if a dependency suddenly stops supporting some platform you still need to support, but you still want to leverage newer features on newer platforms. I have a similar problem with the FSharp.Core packages here (and I don't like it at all, that's why it is a prerelease for testing only) |
I know, but still... I created a new Paket issue (fsprojects/Paket#220) which could solve this. What do you guys think? |
Please try to use |
While I think this would work here this is a major bug in paket now: If you watch closely Paket references the net45 dll which is build against an higher version of System.Web.Razor.dll while still using the old net40 System.Web.Razor.dll... this could lead to compiler errors in the best case (missing method exception?). I read the nuget package this way: When using the .net45 dll you are not allowed to use a lower version than 3.2.2 (because I could have used new features of this dependency). So the only resolution for Paket is to use the net40 dll in both cases. You said net45 profile is not build in FSharp.Formatting so it shouldn't matter, but the generated dependencies are now just wrong (for net45), should I use this anyway? |
we will solve this issue soon. The new install model will propably fix this. I think it'sa ok for now. |
Done, see updated commits in: #207 |
#202 suggests this is possible
The text was updated successfully, but these errors were encountered: