Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if Base property on tcImports indeed exists inside ProvidedTypesContext.Create #179

Merged
merged 1 commit into from
Nov 28, 2017

Conversation

Jand42
Copy link
Contributor

@Jand42 Jand42 commented Nov 27, 2017

I have encountered the very same error as described in #177 in a different context: checking a project using a TP with FCS running inside an ASP.NET application (both the web application and and the checked project are targeting .NET 4.6).

I have found that a null check on dllInfo value inside ProvidedTypesContext.Create before using it eliminates this error and I could not find any regression.

@dsyme dsyme merged commit 33fd1c0 into fsprojects:master Nov 28, 2017
@dsyme
Copy link
Contributor

dsyme commented Nov 28, 2017

@Jand42 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants