Delete cached errors if all sources fail - references #908

fsprojects · Jun 29, 2015 · 42ab811 · 42ab811
1 parent ddd0ea2
commit 42ab811
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md
@@ -1,3 +1,6 @@
+#### 1.18.5 - 29.06.2015
+* BUGFIX: Delete cached errors if all sources fail - https://github.com/fsprojects/Paket/issues/908
+
 #### 1.18.4 - 29.06.2015
 * COSMETICS: Better error message when package doesn't exist
 

diff --git a/src/Paket.Core/NuGetV2.fs b/src/Paket.Core/NuGetV2.fs
@@ -284,6 +284,14 @@ let private loadFromCacheOrOData force fileName auth nugetURL package version =
             return true,details
     }
 
+let deleteErrorFile (packageName:PackageName) =
+    let di = DirectoryInfo(CacheFolder)
+    for errorFile in di.GetFiles(sprintf "*%O*.failed" packageName) do
+        try
+            File.Delete(errorFile.FullName)
+        with
+        | _ -> ()
+
 /// Tries to get download link and direct dependencies from Nuget
 /// Caches calls into json file
 let getDetailsFromNuget force auth nugetURL package (version:SemVerInfo) = 
@@ -617,6 +625,7 @@ let GetPackageDetails root force sources packageName (version:SemVerInfo) : Pack
               verbosefn "Source '%O' exception: %O" source e
               tryNext rest
         | [] -> 
+            deleteErrorFile packageName
             match sources with
             | [source] ->
                 failwithf "Couldn't get package details for package %s %s on %s." package (version.ToString()) (source.ToString())

diff --git a/src/Paket/Paket.fsproj b/src/Paket/Paket.fsproj
@@ -48,8 +48,8 @@
     <WarningLevel>3</WarningLevel>
     <DocumentationFile>
     </DocumentationFile>
-    <StartArguments>install</StartArguments>
-    <StartWorkingDirectory>D:\code\RethinkDB.Demo</StartWorkingDirectory>
+    <StartArguments>update</StartArguments>
+    <StartWorkingDirectory>D:\code\paketkopie</StartWorkingDirectory>
   </PropertyGroup>
   <PropertyGroup>
     <MinimumVisualStudioVersion Condition="'$(MinimumVisualStudioVersion)' == ''">11</MinimumVisualStudioVersion>