Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

binding redirects from the last group always win. #1284

Closed
Karamell opened this issue Dec 3, 2015 · 5 comments
Closed

binding redirects from the last group always win. #1284

Karamell opened this issue Dec 3, 2015 · 5 comments

Comments

@Karamell
Copy link
Contributor

Karamell commented Dec 3, 2015

This is probably related to #1218 .

If i clone paket and then run paket install --redirects (on paket itself) all App.config is rewritten to only contain binding redirects from the last group in the lock file. Easily reproduced.

Am I using packet wrong?

@forki
Copy link
Member

forki commented Dec 3, 2015

I don't think this is what's going on. The last group from the lockfile is "Test" and I don't see NUnit Bindings.

Try paket install --redirects --hard and it basically removes all entries since the current logic decides there are no conflicts. The FSharp.Core entries are still needed so we discussed with @mrinaldi that we need a force option.

@Karamell
Copy link
Contributor Author

Karamell commented Dec 3, 2015

I'm sorry I misunderstood. The missing FSharp.Core is a different problem.

Try and add modify the app.config-file to this:

<dependentAssembly>
 <bindingRedirect oldVersion="0.0.0.0-999.999.999.999" newVersion="7.0.0.0" />
    <Paket>True</Paket> <!-- important -->
       <bindingRedirect oldVersion="0.0.0.0-999.999.999.999" newVersion="7.0.0.0" />
</dependentAssembly>

you'll see it will be removed.

The next run Paket will first be add the bindings from the Main group, then removed everything in the Build group... and again in the Test group.

the <Paket>True</Paket> concept does not work with groups.

@forki
Copy link
Member

forki commented Dec 3, 2015

tried to fix this in #1286 - @mrinaldi do you think this is correct?

@forki
Copy link
Member

forki commented Dec 3, 2015

@Karamell I activated this in 2.23.2 could you please check if it works for you?

@Karamell
Copy link
Contributor Author

Karamell commented Dec 3, 2015

it works for me @forki Both my own project and the paket project is ok.

Thanks for fixing it so fast CI/CD FTW!

@forki forki closed this as completed Dec 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants